From reviews-return-59765-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 28 00:44:24 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5085F1824B for ; Fri, 28 Apr 2017 00:44:24 +0000 (UTC) Received: (qmail 1321 invoked by uid 500); 28 Apr 2017 00:44:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 1288 invoked by uid 500); 28 Apr 2017 00:44:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 1277 invoked by uid 99); 28 Apr 2017 00:44:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 00:44:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 923311818E9 for ; Fri, 28 Apr 2017 00:44:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Mm1uFejTmZpc for ; Fri, 28 Apr 2017 00:44:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0D7065F36C for ; Fri, 28 Apr 2017 00:44:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 70B44E069F; Fri, 28 Apr 2017 00:44:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5EF98C40718; Fri, 28 Apr 2017 00:44:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0635628583366893074==" MIME-Version: 1.0 Subject: Review Request 58829: Fixed the implementation of per-role Suppress / Revive calls. From: Benjamin Mahler To: Michael Park Cc: Benjamin Mahler , mesos Date: Fri, 28 Apr 2017 00:44:21 -0000 Message-ID: <20170428004421.10790.52681@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58829/ X-Sender: Benjamin Mahler Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============0635628583366893074== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58829/ ----------------------------------------------------------- Review request for mesos and Michael Park. Bugs: MESOS-7430 https://issues.apache.org/jira/browse/MESOS-7430 Repository: mesos Description ------- The existing implementation uses a single suppression boolean which results in incorrect handling of per-role suppression / revival. See: https://issues.apache.org/jira/browse/MESOS-7430 Diffs ----- src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6 src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa Diff: https://reviews.apache.org/r/58829/diff/1/ Testing ------- make check Thanks, Benjamin Mahler --===============0635628583366893074==--