From reviews-return-59764-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 28 00:43:45 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7FED018244 for ; Fri, 28 Apr 2017 00:43:45 +0000 (UTC) Received: (qmail 99983 invoked by uid 500); 28 Apr 2017 00:43:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99956 invoked by uid 500); 28 Apr 2017 00:43:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99939 invoked by uid 99); 28 Apr 2017 00:43:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 00:43:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 72E4B1818E9 for ; Fri, 28 Apr 2017 00:43:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7bDsTs_FB3Zf for ; Fri, 28 Apr 2017 00:43:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1F3F75F306 for ; Fri, 28 Apr 2017 00:43:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C6CEE069F; Fri, 28 Apr 2017 00:43:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6ACD7C40718; Fri, 28 Apr 2017 00:43:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8237460452969468438==" MIME-Version: 1.0 Subject: Review Request 58828: Replaced std::set with hashset for framework roles. From: Benjamin Mahler To: Michael Park Cc: Benjamin Mahler , mesos Date: Fri, 28 Apr 2017 00:43:42 -0000 Message-ID: <20170428004342.10791.75903@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58828/ X-Sender: Benjamin Mahler Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============8237460452969468438== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58828/ ----------------------------------------------------------- Review request for mesos and Michael Park. Repository: mesos Description ------- Since we do not need ordering, this updates the framework roles to be stored using hashset instead of std::set. Diffs ----- src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6 src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6 src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 src/master/master.cpp a0cb505a1300637f42fa8062c57deb1590779dd4 src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a src/tests/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328 Diff: https://reviews.apache.org/r/58828/diff/1/ Testing ------- make check Thanks, Benjamin Mahler --===============8237460452969468438==--