From reviews-return-59646-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 26 19:05:11 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 997E219D6E for ; Wed, 26 Apr 2017 19:05:11 +0000 (UTC) Received: (qmail 65827 invoked by uid 500); 26 Apr 2017 19:05:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 65793 invoked by uid 500); 26 Apr 2017 19:05:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65770 invoked by uid 99); 26 Apr 2017 19:05:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2017 19:05:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8C081D578C; Wed, 26 Apr 2017 19:05:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id HSMpYXV-3C0U; Wed, 26 Apr 2017 19:05:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 062885F659; Wed, 26 Apr 2017 19:05:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A22B1E0C0D; Wed, 26 Apr 2017 19:05:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0D7D4C4029A; Wed, 26 Apr 2017 19:05:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3488868986668977607==" MIME-Version: 1.0 Subject: Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280. From: Jie Yu To: Jie Yu , Vinod Kone , Gilbert Song Cc: Chun-Hung Hsiao , mesos Date: Wed, 26 Apr 2017 19:05:04 -0000 Message-ID: <20170426190504.64641.74467@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58640/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20170422015614.23979.26433@reviews-vm2.apache.org> In-Reply-To: <20170422015614.23979.26433@reviews-vm2.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============3488868986668977607== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review173078 ----------------------------------------------------------- Fix it, then Ship it! src/tests/containerizer/provisioner_docker_tests.cpp Lines 827 (patched) EXPECT_SOME - Jie Yu On April 22, 2017, 1:56 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58640/ > ----------------------------------------------------------- > > (Updated April 22, 2017, 1:56 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7280 > https://issues.apache.org/jira/browse/MESOS-7280 > > > Repository: mesos > > > Description > ------- > > Created a non-empty file 'abc' under the agent's work directory, which > is linked by the symlink '/xyz' in the 2nd layer of the testing image. > This file should not be overwritten by the empty file '/xyz' in the 3rd > layer. Please see the following link for more details: > https://hub.docker.com/r/chhsiao/overwrite/ > The testing image is updated in a way that it is compatible to the > previous Overwrite test. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp c26e1f9b093fda66f14e474006d8148c0b9f3245 > > > Diff: https://reviews.apache.org/r/58640/diff/1/ > > > Testing > ------- > > sudo make test > Manually tested on commit bc12a58 to make sure that the 'abc' becomes empty in the unpatched copy backend. > > > Thanks, > > Chun-Hung Hsiao > > --===============3488868986668977607==--