From reviews-return-59439-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 20 17:18:25 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A585A192D0 for ; Thu, 20 Apr 2017 17:18:25 +0000 (UTC) Received: (qmail 72915 invoked by uid 500); 20 Apr 2017 17:18:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 72881 invoked by uid 500); 20 Apr 2017 17:18:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72870 invoked by uid 99); 20 Apr 2017 17:18:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2017 17:18:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D5EF71813F6; Thu, 20 Apr 2017 17:18:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1NC3E7qSIqDG; Thu, 20 Apr 2017 17:18:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CE3E45F1D5; Thu, 20 Apr 2017 17:18:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7B90CE00A6; Thu, 20 Apr 2017 17:18:23 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6BF53C40387; Thu, 20 Apr 2017 17:18:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3982139978172125210==" MIME-Version: 1.0 Subject: Re: Review Request 58512: Avoid a crash in HTTP decoder. From: Anindya Sinha To: Anand Mazumdar , James Peach , Jiang Yan Xu Cc: Mesos Reviewbot , Anindya Sinha , mesos Date: Thu, 20 Apr 2017 17:18:23 -0000 Message-ID: <20170420171823.24124.29026@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58512/ X-Sender: Anindya Sinha References: <20170419160209.32394.14901@reviews-vm2.apache.org> In-Reply-To: <20170419160209.32394.14901@reviews-vm2.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos --===============3982139978172125210== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/ ----------------------------------------------------------- (Updated April 20, 2017, 5:18 p.m.) Review request for mesos, Anand Mazumdar, James Peach, and Jiang Yan Xu. Bugs: MESOS-7400 https://issues.apache.org/jira/browse/MESOS-7400 Repository: mesos Description ------- If the callback `on_headers_complete()` fails, the decoder's writer object is `None()`. So, when the callback `on_message_complete()` is called, we should not crash in that case. Note that the `CHECK(decoder->writer)` is valid for the callback `on_body()` is valid since this callback is called only on a success in `on_headers_complete()` callback. Diffs (updated) ----- 3rdparty/libprocess/src/decoder.hpp 4c779d42548958e610142438a57529ccb4478053 3rdparty/libprocess/src/tests/decoder_tests.cpp c0efef571815752cc28e5a0dc7a07adc82bb31d5 Diff: https://reviews.apache.org/r/58512/diff/3/ Changes: https://reviews.apache.org/r/58512/diff/2-3/ Testing ------- All tests passed. Thanks, Anindya Sinha --===============3982139978172125210==--