From reviews-return-59140-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 13 22:45:40 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C7A2D18248 for ; Thu, 13 Apr 2017 22:45:40 +0000 (UTC) Received: (qmail 81756 invoked by uid 500); 13 Apr 2017 22:45:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81719 invoked by uid 500); 13 Apr 2017 22:45:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81708 invoked by uid 99); 13 Apr 2017 22:45:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 22:45:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 03F51C075B; Thu, 13 Apr 2017 22:45:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Dx5p1pc7EGiX; Thu, 13 Apr 2017 22:45:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BE6965FC7A; Thu, 13 Apr 2017 22:45:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D357E0026; Thu, 13 Apr 2017 22:45:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DA928C400D1; Thu, 13 Apr 2017 22:45:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2671059626145594831==" MIME-Version: 1.0 Subject: Re: Review Request 58368: Updated 'HealthChecker' to authenticate with the agent. From: Vinod Kone To: Anand Mazumdar , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone , Alexander Rukletsov Cc: Greg Mann , mesos Date: Thu, 13 Apr 2017 22:45:37 -0000 Message-ID: <20170413224537.5224.78327@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58368/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20170412092051.22151.70623@reviews-vm2.apache.org> In-Reply-To: <20170412092051.22151.70623@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============2671059626145594831== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58368/#review171954 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On April 12, 2017, 9:20 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58368/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 9:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Gastón Kleiman, and Vinod Kone. > > > Bugs: MESOS-7377 > https://issues.apache.org/jira/browse/MESOS-7377 > > > Repository: mesos > > > Description > ------- > > This patch updates the `HealthChecker` to permit initialization > with an authorization header, which it will provide to the agent > operator API for authentication when present. > > > Diffs > ----- > > src/checks/health_checker.hpp e17f12f75d388443f6592455177f5bdae31b7c0f > src/checks/health_checker.cpp 769278c40b5e505dc49a49a23d8c0dd97f201a53 > > > Diff: https://reviews.apache.org/r/58368/diff/1/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > > --===============2671059626145594831==--