From reviews-return-58982-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 11 18:59:33 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0658A18B23 for ; Tue, 11 Apr 2017 18:59:33 +0000 (UTC) Received: (qmail 7712 invoked by uid 500); 11 Apr 2017 18:59:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 7687 invoked by uid 500); 11 Apr 2017 18:59:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 7378 invoked by uid 99); 11 Apr 2017 18:59:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Apr 2017 18:59:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D6FC51AFB26; Tue, 11 Apr 2017 18:59:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id G0JiEvsW5LEE; Tue, 11 Apr 2017 18:59:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F32B55F5CA; Tue, 11 Apr 2017 18:59:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63EF9E0142; Tue, 11 Apr 2017 18:59:28 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 55610C401AA; Tue, 11 Apr 2017 18:59:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0869147538664226995==" MIME-Version: 1.0 Subject: Re: Review Request 58351: Updated GMock/GTest in libprocess. From: Mesos Reviewbot To: Neil Conway , Till Toenshoff Cc: Mesos Reviewbot , Jan Schlicht , mesos Date: Tue, 11 Apr 2017 18:59:28 -0000 Message-ID: <20170411185928.22151.14083@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58351/ X-Sender: Mesos Reviewbot References: <20170411123119.15481.6085@reviews-vm2.apache.org> In-Reply-To: <20170411123119.15481.6085@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0869147538664226995== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58351/#review171609 ----------------------------------------------------------- Bad patch! Reviews applied: [58351, 58350, 58349, 58348, 58347] Failed command: python support/apply-reviews.py -n -r 58349 Error: 2017-04-11 18:59:27 URL:https://reviews.apache.org/r/58349/diff/raw/ [13902/13902] -> "58349.patch" [1] error: missing binary patch data for '3rdparty/googletest-release-1.8.0.tar.gz' error: binary patch does not apply to '3rdparty/googletest-release-1.8.0.tar.gz' error: 3rdparty/googletest-release-1.8.0.tar.gz: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/17724/console - Mesos Reviewbot On April 11, 2017, 12:31 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58351/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 12:31 p.m.) > > > Review request for mesos, Neil Conway and Till Toenshoff. > > > Bugs: MESOS-7364 > https://issues.apache.org/jira/browse/MESOS-7364 > > > Repository: mesos > > > Description > ------- > > This will fix various issues that occured with version 1.7.0. > As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some > test cases have been updated accordingly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 9dc5fb51d8120d0b26b3f158f69191e468694275 > 3rdparty/libprocess/Makefile.am 80758d60cd2b391105c30151883c3c7dbf763a31 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 31e20e475a4f51ea74eeebae2a026264589e8dda > 3rdparty/libprocess/configure.ac 1540006e6189cf6618d7f1df4d4b9544bd1c25ea > 3rdparty/libprocess/include/process/gmock.hpp 05d8b8e55ab3aa526adb0f7df4683cbd535926f8 > > > Diff: https://reviews.apache.org/r/58351/diff/1/ > > > Testing > ------- > > make check (on macOS, Linux, Windows) > > > Thanks, > > Jan Schlicht > > --===============0869147538664226995==--