From reviews-return-58659-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 4 17:43:08 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2D2A18ABF for ; Tue, 4 Apr 2017 17:43:08 +0000 (UTC) Received: (qmail 82010 invoked by uid 500); 4 Apr 2017 17:43:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81974 invoked by uid 500); 4 Apr 2017 17:43:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81959 invoked by uid 99); 4 Apr 2017 17:43:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2017 17:43:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 156351AF8F1; Tue, 4 Apr 2017 17:43:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5xwg6slaqLwH; Tue, 4 Apr 2017 17:43:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DBB955FBA1; Tue, 4 Apr 2017 17:43:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A76AE0185; Tue, 4 Apr 2017 17:43:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6BFA7C4047F; Tue, 4 Apr 2017 17:43:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4730742933446208152==" MIME-Version: 1.0 Subject: Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'. From: Andrew Schwartzmeyer To: Anand Mazumdar , Michael Park , Vinod Kone Cc: Greg Mann , mesos Date: Tue, 04 Apr 2017 17:43:06 -0000 Message-ID: <20170404174306.22168.53246@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58175/ X-Sender: Andrew Schwartzmeyer References: <20170404174214.22168.7456@reviews-vm2.apache.org> In-Reply-To: <20170404174214.22168.7456@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============4730742933446208152== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 4, 2017, 5:42 p.m., Andrew Schwartzmeyer wrote: > > Ship It! This patch fixes the `CombinedAuthenticatorTest.MultipleAuthenticators` test failure that otherwise reproduces on Windows 10 with the VS 2017 tools. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58175/#review170995 ----------------------------------------------------------- On April 4, 2017, 2:15 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58175/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 2:15 p.m.) > > > Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch updates the `loop()` logic within > `CombinedAuthenticatorProcess::authenticate()` to fix a bug > in which an iterator is incremented past the end of its vector. > > > Diffs > ----- > > src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 > > > Diff: https://reviews.apache.org/r/58175/diff/1/ > > > Testing > ------- > > `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"` > > > Thanks, > > Greg Mann > > --===============4730742933446208152==--