mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58820: Explained how container working directory differs from its sandbox.
Date Fri, 28 Apr 2017 20:37:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58820/#review173378
-----------------------------------------------------------




include/mesos/slave/containerizer.proto
Line 186 (original), 186 (patched)
<https://reviews.apache.org/r/58820/#comment246384>

    s/sandbox/sandbox in the host (or is it container?) mount namespace/ ?
    
    also, not clear what "Mesos sandbox" means? do you mean the value of 'MESOS_SANDBOX' env
variable?



include/mesos/slave/containerizer.proto
Lines 187 (patched)
<https://reviews.apache.org/r/58820/#comment246383>

    s/the image/an image/


- Vinod Kone


On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58820/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 4:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2 
>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

> 
> 
> Diff: https://reviews.apache.org/r/58820/diff/2/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message