mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.
Date Fri, 28 Apr 2017 16:38:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58262/#review173338
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.hpp
Lines 367 (patched)
<https://reviews.apache.org/r/58262/#comment246357>

    I think we should store `Option<ContainerLaunchInfo>` here so that we don't end
up adding more and more field in Info struct.


- Jie Yu


On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58262/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 4:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6782
>     https://issues.apache.org/jira/browse/MESOS-6782
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82

> 
> 
> Diff: https://reviews.apache.org/r/58262/diff/6/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58718/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message