mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.
Date Fri, 28 Apr 2017 16:15:02 GMT


> On April 27, 2017, 11:15 p.m., Jie Yu wrote:
> >
> 
> Jie Yu wrote:
>     See my comments in https://reviews.apache.org/r/58263/
>     
>     We should probably just checkpoint `ContainerLaunchInfo`.

Yeah, this sounds like a good idea. Checkpoint the whole `ContainerLaunchInfo`, but restore
only environment and working directory for now. I'll update the chain.


> On April 27, 2017, 11:15 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1468-1469 (patched)
> > <https://reviews.apache.org/r/58262/diff/5/?file=1702147#file1702147line1469>
> >
> >     Should we return failure here? If we launch a debug container later under this
container, will it silently miss some environment variables?

I think it is not fatal if it's just environment, however, this is questionable. In any way,
since we now will be checkpointing the whole `ContainerLaunchInfo`, I think it makes sense
to propagate the checkpointing failure if any. Dropping this since the code will be migrated.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58262/#review173266
-----------------------------------------------------------


On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58262/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 4:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6782
>     https://issues.apache.org/jira/browse/MESOS-6782
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82

> 
> 
> Diff: https://reviews.apache.org/r/58262/diff/6/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58718/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message