mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume.
Date Fri, 28 Apr 2017 15:42:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
-----------------------------------------------------------

(Updated April 28, 2017, 3:42 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
-------

Rebased. Yet to address the review comments.


Bugs: MESOS-7308
    https://issues.apache.org/jira/browse/MESOS-7308


Repository: mesos


Description
-------

In `updateAllocation()`, it is possible for the flattened scalar
quantites of original framework allocation to differ from the updated
framework allocation. This can happen when an offer with a shared
persistent volume is sent out after a DESTROY has been received. If
that is the case, we rescind the pending offers from all frameworks
which contain the volumes to be destroyed.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 6eda1b8619269c1501a935045b18b1deaf845b33 
  src/master/allocator/mesos/allocator.hpp 57b54b86c43c7731e64d422d285c4b8ca7e27a60 
  src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6 
  src/master/allocator/mesos/hierarchical.cpp 84dc31dd6e567e9316a73c61e03a1daf6f556829 
  src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 
  src/master/master.cpp e8c2a96ff3407fb429e60cd9e66a8c4dc52b391b 
  src/tests/allocator.hpp 6b71c574e0e4facd1795ef50ee0869c03b87833d 
  src/tests/hierarchical_allocator_tests.cpp 84bb6f302f6ff6f8a93fa891795df9ef7380629f 


Diff: https://reviews.apache.org/r/58486/diff/3/

Changes: https://reviews.apache.org/r/58486/diff/2-3/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message