mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.
Date Thu, 27 Apr 2017 23:43:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173273
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 1504-1506 (original), 1535-1546 (patched)
<https://reviews.apache.org/r/58263/#comment246313>

    That makes me think that maybe we should just checkpoint `ContainerLaunchInfo`? That sounds
like more extensible?


- Jie Yu


On April 27, 2017, 10:17 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 10:17 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7433
>     https://issues.apache.org/jira/browse/MESOS-7433
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

>   src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b 
>   src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82

> 
> 
> Diff: https://reviews.apache.org/r/58263/diff/3/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58821/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message