mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.
Date Thu, 27 Apr 2017 22:10:38 GMT


> On April 26, 2017, 3:58 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1396 (patched)
> > <https://reviews.apache.org/r/58262/diff/4/?file=1699832#file1699832line1396>
> >
> >     I'd suggest we list the priority for environments for debug container here in
the comments as well.
> >     ```
> >     1) user specified env
> >     2) returned by isolators
> >     3) passed from containerizer
> >     4) inheirited from the parent
> >     ```
> 
> Vinod Kone wrote:
>     Are either 2) or 3) specified by the operator? If yes, should operator be able to
override user's env settings?
> 
> Alexander Rukletsov wrote:
>     I'm not sure we should include containerizer env for debug containers. It will most
probably only lead to duplicates, because this env will already be inherited from the parent.

containerizer env for any nested container should be empty at the moment.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58262/#review173020
-----------------------------------------------------------


On April 25, 2017, 9:06 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58262/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 9:06 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6782
>     https://issues.apache.org/jira/browse/MESOS-6782
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

>   src/slave/containerizer/mesos/containerizer.cpp 56db7eb1193c9812b62b9149c9c2b2dd9b66701c

>   src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b 
>   src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82

> 
> 
> Diff: https://reviews.apache.org/r/58262/diff/4/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58718/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message