mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.
Date Thu, 27 Apr 2017 22:06:36 GMT


> On April 13, 2017, 12:47 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.hpp
> > Lines 325 (patched)
> > <https://reviews.apache.org/r/58263/diff/2/?file=1686501#file1686501line325>
> >
> >     Can you elaborate how it is different?
> 
> Alexander Rukletsov wrote:
>     I can, but I'm not sure this is the right place. I do think we need a proper explanation
of the difference, maybe https://github.com/apache/mesos/blob/c702150297da99cc62804aad77057f1948d33714/include/mesos/slave/containerizer.proto#L185-L187
is a better place for this? How about I address it in a separate patch and here I mention
we cache the field fron the proto?

Addressed in https://reviews.apache.org/r/58820/


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171830
-----------------------------------------------------------


On April 25, 2017, 9:12 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 9:12 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

>   src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6

> 
> 
> Diff: https://reviews.apache.org/r/58263/diff/2/
> 
> 
> Testing
> -------
> 
> make check on Mac OS.
> Linux pending.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message