mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 58758: Added secret to Image.{docker, appc} and ContainerInfo.volume.
Date Thu, 27 Apr 2017 20:27:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58758/#review173253
-----------------------------------------------------------



Please address the comments and add the same changes to v1/mesos.proto


include/mesos/mesos.proto
Lines 2112-2113 (patched)
<https://reviews.apache.org/r/58758/#comment246296>

    The change on `Image` is already merged. Please discard this part.



include/mesos/mesos.proto
Lines 2216 (patched)
<https://reviews.apache.org/r/58758/#comment246297>

    Could we add some comments?


- Gilbert Song


On April 26, 2017, 4:38 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58758/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 4:38 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added secret to Image.{docker,appc} and ContainerInfo.volume.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 
> 
> 
> Diff: https://reviews.apache.org/r/58758/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message