mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58718: Added a test that verifies a task's env var is seen by its check.
Date Thu, 27 Apr 2017 20:18:20 GMT


> On April 26, 2017, 10:05 p.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp
> > Lines 521 (patched)
> > <https://reviews.apache.org/r/58718/diff/1/?file=1699836#file1699836line521>
> >
> >     Move this to #548?

We could, but then it'll be inconsisten with all other tests in this file. Having said that,
we can do this change, but in a separate patch.


> On April 26, 2017, 10:05 p.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp
> > Lines 556-557 (patched)
> > <https://reviews.apache.org/r/58718/diff/1/?file=1699836#file1699836line556>
> >
> >     Why does one take a ref and other a copy?

I don't think there is a particular reason for this. I see similar issue in "slave_tests.cpp",
let me fix all instances at once in a separate patch.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58718/#review173111
-----------------------------------------------------------


On April 25, 2017, 9:06 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58718/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 9:06 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35 
> 
> 
> Diff: https://reviews.apache.org/r/58718/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on various Linux distributions.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message