mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.
Date Thu, 27 Apr 2017 15:05:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/#review173207
-----------------------------------------------------------




src/tests/master_authorization_tests.cpp
Line 2063 (original), 2062 (patched)
<https://reviews.apache.org/r/58097/#comment246265>

    Not yours, but no test verifies that the serialzation of quotas/weights is done correctly.
Since you are changing how it is performed, coul you test that too?


- Alexander Rojas


On April 19, 2017, 5:38 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58097/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 5:38 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7260
>     https://issues.apache.org/jira/browse/MESOS-7260
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to check framework filtering in /roles endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp 1a0285a3f345ef21a8256d4123d8bb684f538da4 
> 
> 
> Diff: https://reviews.apache.org/r/58097/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message