mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 57474: Added test for authorization of hierarchical roles.
Date Thu, 27 Apr 2017 07:09:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57474/#review173164
-----------------------------------------------------------


Fix it, then Ship it!




LGTM. I will fix the tiny typo when I commit.


src/tests/authorization_tests.cpp
Line 1493 (original), 1493 (patched)
<https://reviews.apache.org/r/57474/#comment246237>

    s/crete/create/


- Adam B


On April 18, 2017, 6:28 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57474/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 6:28 a.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Bannier.
> 
> 
> Bugs: MESOS-7026
>     https://issues.apache.org/jira/browse/MESOS-7026
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds tests for each of the actions which support hierarchical roles.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d 
> 
> 
> Diff: https://reviews.apache.org/r/57474/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message