mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 58708: Checked validity of master and agent version numbers on startup.
Date Wed, 26 Apr 2017 23:20:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/#review172998
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, just seems to be in an inconsistent location across the master and agent files?


src/master/main.cpp
Lines 252-260 (patched)
<https://reviews.apache.org/r/58708/#comment246060>

    It seems like this is in a different spot across the agent and master code, seems to me
like we should do this before flag loading and build info logging in both cases.
    
    Since this will be an error regardless of getting the flags right.


- Benjamin Mahler


On April 26, 2017, 5:35 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58708/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 5:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-6976
>     https://issues.apache.org/jira/browse/MESOS-6976
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> During startup, we now check that the compiled-in version number of the
> master and agent can be parsed by stout's `Version::parse` (i.e., that
> `MESOS_VERSION` is valid according to stout's extended variant of the
> Semver 2.0.0 format).
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7 
>   src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52 
> 
> 
> Diff: https://reviews.apache.org/r/58708/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message