mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.
Date Wed, 26 Apr 2017 23:12:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58747/
-----------------------------------------------------------

(Updated April 26, 2017, 4:12 p.m.)


Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, and Jie Yu.


Bugs: MESOS-7272
    https://issues.apache.org/jira/browse/MESOS-7272


Repository: mesos


Description (updated)
-------

This check was introduced from this patch:
https://reviews.apache.org/r/53848/

The check on registry v2 schema 1 is incorrect. It does not work
for registries that are older version < 2.3, because the ContentType
header may be something like this "application/json; charset=utf-8".
The check missed a note from docker registry spec that
"application/json" will also be accepted for schema 1.

Depending on the docker registry spec doc, docker support the
following three media type for V2 schema 1 manifest:
  1. application/vnd.docker.distribution.manifest.v1+json
  2. application/vnd.docker.distribution.manifest.v1+prettyjws
  3. application/json
For more details, see:
  https://docs.docker.com/registry/spec/manifest-v2-1/


Diffs (updated)
-----

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58747/diff/2/

Changes: https://reviews.apache.org/r/58747/diff/1-2/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message