mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 58687: Made the activation of a client in `Sorter::add` explicit.
Date Wed, 26 Apr 2017 22:47:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58687/
-----------------------------------------------------------

(Updated April 26, 2017, 3:47 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.


Changes
-------

Addressed bmahler's comments.


Bugs: MESOS-7323
    https://issues.apache.org/jira/browse/MESOS-7323


Repository: mesos


Description (updated)
-------

Made the activation of a client in `Sorter::add` explicit.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa 
  src/master/allocator/sorter/drf/sorter.cpp 73b8e8ccdee9d1a88bf6a1726b8ff67008ef339f 
  src/master/allocator/sorter/sorter.hpp 0c9f17255e9ed9dea56322bf7633505faf2a1a33 
  src/tests/sorter_tests.cpp 3d183bf3602ed632cbe8242c90a499d2e7848499 


Diff: https://reviews.apache.org/r/58687/diff/2/

Changes: https://reviews.apache.org/r/58687/diff/1-2/


Testing
-------

`make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message