mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies.
Date Wed, 26 Apr 2017 21:01:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58447/#review173016
-----------------------------------------------------------


Ship it!




I'm going to make a couple minor whitespace additions (to make things consistent within the
files).  But otherwise LGTM.


3rdparty/CMakeLists.txt
Line 46 (original), 26-27 (patched)
<https://reviews.apache.org/r/58447/#comment246089>

    Whitespace things like: 2 spaces before each of these sections.



3rdparty/CMakeLists.txt
Lines 54-55 (original), 51-52 (patched)
<https://reviews.apache.org/r/58447/#comment246090>

    And one newline before comments like this.


- Joseph Wu


On April 13, 2017, 7:03 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58447/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 7:03 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit removes duplicate code from `3rdparty/CMakeLists.txt`,
> and consolidates platform-specific versions into `Versions.cmake`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake c60652688a23f8628f133b7890ff39e38fc8ae94

>   3rdparty/cmake/Versions.cmake 912726351ff744dd839b8d1c8d64dcc373d879be 
>   cmake/CompilationConfigure.cmake 1c5466960f5ac73b8fc81edf7950cc68ed744301 
> 
> 
> Diff: https://reviews.apache.org/r/58447/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message