mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.
Date Wed, 26 Apr 2017 19:28:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173083
-----------------------------------------------------------


Fix it, then Ship it!




Have you tested with all registries that we support?


src/uri/fetchers/docker.cpp
Lines 472 (patched)
<https://reviews.apache.org/r/58725/#comment246151>

    one line above.



src/uri/fetchers/docker.cpp
Lines 504-505 (patched)
<https://reviews.apache.org/r/58725/#comment246150>

    I'd introduce:
    ```
    class Headers {
    public:
      http::Headers operator+(const http::Headers& that) const;
    }
    ```
    
    so that you can do:
    ```
    curl(manifestUri, authHeaders + manifestHeaders)
    ```


- Jie Yu


On April 26, 2017, 6:20 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 6:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
>     https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message