mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.
Date Wed, 26 Apr 2017 19:14:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58747/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, and Jie Yu.


Bugs: MESOS-7272
    https://issues.apache.org/jira/browse/MESOS-7272


Repository: mesos


Description
-------

This check was introduced from this patch:
https://reviews.apache.org/r/53848/

The check on registry v2 schema 1 is too strict. It does not work
for registries that are older version < 2.3, because the ContentType
header may be something like this "application/json; charset=utf-8".
No schema information is included in the manifest header for old
registries.


Diffs
-----

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58747/diff/1/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message