mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.
Date Wed, 26 Apr 2017 18:20:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/
-----------------------------------------------------------

(Updated April 26, 2017, 6:20 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Addressed Gilbert's comments.


Bugs: MESOS-7427
    https://issues.apache.org/jira/browse/MESOS-7427


Repository: mesos


Description
-------

Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
to the headers of HTTP requests for fetching manifests from any Docker
registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
field strictly and reject the requests if it is not specified.


Diffs (updated)
-----

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58725/diff/2/

Changes: https://reviews.apache.org/r/58725/diff/1-2/


Testing
-------

sudo make check
Manually tested on a local docker private registry and an Amazon ECR repository.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message