mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.
Date Wed, 26 Apr 2017 17:16:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173063
-----------------------------------------------------------




src/uri/fetchers/docker.cpp
Lines 474 (patched)
<https://reviews.apache.org/r/58725/#comment246135>

    Please fix the indentation.



src/uri/fetchers/docker.cpp
Lines 476 (patched)
<https://reviews.apache.org/r/58725/#comment246136>

    Could you paste the link to the docker doc for `Accept` header.


- Gilbert Song


On April 25, 2017, 5:30 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 5:30 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
>     https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message