mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 58688: Removed an incorrect CHECK in the master.
Date Tue, 25 Apr 2017 23:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58688/#review173006
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On April 24, 2017, 11:18 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58688/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 11:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.
> 
> 
> Bugs: MESOS-7323
>     https://issues.apache.org/jira/browse/MESOS-7323
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This CHECK is incorrect because a task can come back from a partitioned agent.
> Specifically,
> 
> 1. If a framework launches a task in role `R`
> 2. The agent that is running the task gets partitioned
> 3. The framework removes `R` from the list of its roles
> 4. The agent rejoins the cluster, reporting the task
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7 
> 
> 
> Diff: https://reviews.apache.org/r/58688/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`, and added a test in https://reviews.apache.org/r/58689
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message