mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles.
Date Mon, 24 Apr 2017 21:24:11 GMT


> On April 20, 2017, 2:26 a.m., Jay Guo wrote:
> > LGTM. I'm looking for MultioRole-related TODOs and see what could be resolved now.
In the future, I feel labeling TODO seems to be a good practice worth calling out in the dev
community.

Yeah, we tried to do that with the "MULTI_ROLE" string, but this one didn't follow the pattern
so of course we missed it :)


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58545/#review172437
-----------------------------------------------------------


On April 19, 2017, 10:32 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58545/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 10:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jay Guo.
> 
> 
> Bugs: MESOS-7368
>     https://issues.apache.org/jira/browse/MESOS-7368
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that the support for frameworks with multiple roles has been
> implemented, we can remove the note about the `FrameworkInfo.roles`
> field having an incomplete implementation.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 
>   include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 
> 
> 
> Diff: https://reviews.apache.org/r/58545/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message