mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.
Date Mon, 24 Apr 2017 21:11:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57516/#review172857
-----------------------------------------------------------




CHANGELOG
Lines 16-17 (patched)
<https://reviews.apache.org/r/57516/#comment245872>

    It would also be nice to mention lack of the full plan here for reservations as well.
E.g. we want reservations to "eng" to go to the "eng" tree instead of just the "eng" role.
    
    Hm.. come to think of it, won't we be breaking things if we have people assuming "eng"
reservations don't go to the tree and we change this?



CHANGELOG
Lines 32-35 (patched)
<https://reviews.apache.org/r/57516/#comment245873>

    AFAICT the sorter headers weren't made public, they were just a detail of our allocator
implementation.


- Benjamin Mahler


On April 20, 2017, 6:14 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57516/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated CHANGELOG for hierarchical roles.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG feaedf7426fe694e4ecf1ade82abca3bf69d1691 
> 
> 
> Diff: https://reviews.apache.org/r/57516/diff/4/
> 
> 
> Testing
> -------
> 
> No functional change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message