mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui.
Date Mon, 24 Apr 2017 20:23:59 GMT


> On April 24, 2017, 6:11 p.m., haosdent huang wrote:
> > src/webui/master/static/home.html
> > Lines 136-139 (original), 136-139 (patched)
> > <https://reviews.apache.org/r/58548/diff/1/?file=1695251#file1695251line136>
> >
> >     hi, @bamhler, do you think if we need to replace `used_` to `allocated_` in
these variables as well?

Currently the master reports "used" as allocated, which is why "Used" made its way into the
table header. We'd have to change the endpoint variables in a backwards compatible manner.
So I opted to leave these as is. Maybe a comment would be good.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58548/#review172829
-----------------------------------------------------------


On April 20, 2017, 1:53 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58548/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 1:53 a.m.)
> 
> 
> Review request for mesos, Miguel Bernadin and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The home page of the webui still uses the word 'Used' to reflect how
> much is allocated, whereas the rest of the pages use 'Allocated' for
> this and 'Used' to indicate how much of the allocation is utilized.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html bd2ffc7cbb51a0c8f0e6fc77c460f17a3aac3c31 
> 
> 
> Diff: https://reviews.apache.org/r/58548/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message