-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58683/#review172841
-----------------------------------------------------------
Ship it!
src/tests/zookeeper_test_server.cpp
Line 130 (original), 130 (patched)
<https://reviews.apache.org/r/58683/#comment245866>
This seems like a typo fix, mind committing it separately?
- Benjamin Mahler
On April 24, 2017, 7:46 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58683/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 7:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used "singular they" based on Chromium's gender neutral code guideline.
>
>
> Diffs
> -----
>
> docs/committer-candidate-checklist.md 3315d081e66a2b1826039753f67c5712251fa537
> docs/versioning.md 3ad12492b779c07edda600af1f691dd439f69569
> src/linux/cgroups.cpp 3a853297eaccc86e55888da21f292f5e37c88733
> src/log/catchup.hpp 1e6d4c2d83cc3799084b186f8abd5a3a14c8d8ce
> src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d
> src/tests/zookeeper_test_server.cpp b33a0014f0785cc8de4a9e019c62c95c0e200733
>
>
> Diff: https://reviews.apache.org/r/58683/diff/1/
>
>
> Testing
> -------
>
> Used the following expression (from https://chromium.googlesource.com/chromium/src/+/master/styleguide/gender_neutral_code.md)
to catch the offending lines.
>
> git grep -wiEI \ '(he)|(she)|(his)|(hers)|(him)|(her)|(guy)|(guys)'
>
>
> Thanks,
>
> Vinod Kone
>
>
|