mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 55897: Add support for not enforcing XFS quotas.
Date Mon, 24 Apr 2017 17:25:25 GMT


> On April 23, 2017, 10:48 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/isolators/xfs/utils.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/55897/diff/2/?file=1667425#file1667425line65>
> >
> >     We started to move toward `enum class` now.
> 
> James Peach wrote:
>     Really? There are only 14 uses of `enum class` ad it is not mentioned in the style
guide AFAICT.

14 uses because it's new. I haven't seen new code use the old enum. Any downsides of using
it here?

Yeah we should add it to the style guide.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55897/#review172731
-----------------------------------------------------------


On March 17, 2017, 2:57 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55897/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5116
>     https://issues.apache.org/jira/browse/MESOS-5116
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add XFS disk isolator support for not enforcing disk quotas on
> containers. While there is a global filesystem configuration option
> to turn off quota enforcement, we should not automatically toggle
> that because we don't know why the operator might have changed that
> configuration. Instead, we use the soft quota limit to implement
> an accounting quota and the hard limit for an enforced quota.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 52f0459421a45b01ce38b17c689633301cd97982

>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 40f1049358ad99d3f213289e36def81c580f07f3

>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp eddd4c37fb42339ca21ecb392dea47acf6b277bb

>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 8018ad348d26bd962357543a5fb9f6cb43ff13b1

>   src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043

> 
> 
> Diff: https://reviews.apache.org/r/55897/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message