mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58622: Document that master message validation is best effort.
Date Mon, 24 Apr 2017 17:25:13 GMT


> On April 24, 2017, 3:56 p.m., Neil Conway wrote:
> > src/master/validation.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/58622/diff/1/?file=1697510#file1697510line65>
> >
> >     Can we link to a JIRA here?
> 
> James Peach wrote:
>     Did you have a specific JIRA in mind? I think MESOS-6903 is intended for this?

I didn't have anything specifically in mind, and MESOS-6903 seems too generic, but when we
say "the longer term remedy ...", it would be good to have a corresponding JIRA. Maybe create
a new JIRA and mark it as "related" to 6903?


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/#review172797
-----------------------------------------------------------


On April 21, 2017, 5:05 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58622/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 5:05 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7372
>     https://issues.apache.org/jira/browse/MESOS-7372
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document that master message validation is best effort.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e 
> 
> 
> Diff: https://reviews.apache.org/r/58622/diff/1/
> 
> 
> Testing
> -------
> 
> None (no code changes).
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message