mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.
Date Mon, 24 Apr 2017 16:59:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58305/
-----------------------------------------------------------

(Updated April 24, 2017, 4:59 p.m.)


Review request for mesos, Mesos Reviewbot and Neil Conway.


Bugs: MESOS-7372
    https://issues.apache.org/jira/browse/MESOS-7372


Repository: mesos


Description
-------

The ReRegisterSlaveMessage message sends a number of fields which have
internal consistency requirements. Add some simple validation checks
to ensure that we have a minimally consistent re-registration request
before proceeding.


Diffs (updated)
-----

  src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7 
  src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e 
  src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa 
  src/tests/master_validation_tests.cpp 555380870ae115004312cfbe9f145faa92049030 


Diff: https://reviews.apache.org/r/58305/diff/11/

Changes: https://reviews.apache.org/r/58305/diff/10-11/


Testing
-------

Make check (Fedora 25). Internal fuzzing.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message