mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 57964: Added a test to verify metrics when shared resources are present.
Date Sat, 22 Apr 2017 17:00:24 GMT


> On April 21, 2017, 10:06 p.m., Jiang Yan Xu wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 1174-1175 (patched)
> > <https://reviews.apache.org/r/57964/diff/2/?file=1677304#file1677304line1174>
> >
> >     The comment doesn't seem right?

Yes, ofcourse. Copy and paste issue. Fixed now.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57964/#review172689
-----------------------------------------------------------


On April 22, 2017, 5 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57964/
> -----------------------------------------------------------
> 
> (Updated April 22, 2017, 5 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7186
>     https://issues.apache.org/jira/browse/MESOS-7186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to verify metrics when shared resources are present.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 
> 
> 
> Diff: https://reviews.apache.org/r/57964/diff/3/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message