mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.
Date Sat, 22 Apr 2017 01:56:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58640/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-7280
    https://issues.apache.org/jira/browse/MESOS-7280


Repository: mesos


Description
-------

Created a non-empty file 'abc' under the agent's work directory, which
is linked by the symlink '/xyz' in the 2nd layer of the testing image.
This file should not be overwritten by the empty file '/xyz' in the 3rd
layer. Please see the following link for more details:
  https://hub.docker.com/r/chhsiao/overwrite/
The testing image is updated in a way that it is compatible to the
previous Overwrite test.


Diffs
-----

  src/tests/containerizer/provisioner_docker_tests.cpp c26e1f9b093fda66f14e474006d8148c0b9f3245



Diff: https://reviews.apache.org/r/58640/diff/1/


Testing
-------

sudo make test
Manually tested on commit bc12a58 to make sure that the 'abc' becomes empty in the unpatched
copy backend.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message