mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 53840: Metric in the allocator to track latency in running allocations.
Date Fri, 21 Apr 2017 17:54:05 GMT


> On April 20, 2017, 6:04 p.m., James Peach wrote:
> > If I understand this correctly, this is publishing a time series of the idle time
between allocator runs. Is that correct? If so, what insight does this metric give and how
should operators interpret it? Why is a simple counter of allocator runs not sufficient?
> 
> Anindya Sinha wrote:
>     So as to determine how frequently (or infrequently) allocation cycles are being run
by the allocator. The counters provide the current count of allocation runs.
> 
> James Peach wrote:
>     As we discussed with @xujyan, this is intended to measure the queueing delay for
allocation dispatches. I'm still not convinced that this is a helpful metric. As implemented,
this appears to measure the time between allocation intervals. I guess you would start the
timer in `HierarchicalAllocatorProcess::allocate` and stop it in `HierarchicalAllocatorProcess::_allocate`.

Yes, that is right. Updated the patch.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/#review172526
-----------------------------------------------------------


On April 21, 2017, 5:53 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53840/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 5:53 p.m.)
> 
> 
> Review request for mesos, James Peach and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6579
>     https://issues.apache.org/jira/browse/MESOS-6579
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a metric 'allocator/mesos/allocation_run_interval_ms' which
> tracks the latency between scheduling an allocation to an actual
> allocation run.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 051f749dd5921a322ca930a042c31814616d38f9

>   src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3 
>   src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 
>   src/tests/hierarchical_allocator_tests.cpp 33e7b455f8664858eb4f03727b076a10c80cd6e0

> 
> 
> Diff: https://reviews.apache.org/r/53840/diff/4/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message