mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.
Date Thu, 20 Apr 2017 15:18:48 GMT


> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote:
> > Ship It!
> 
> Andrew Schwartzmeyer wrote:
>     Hey, just wondering, why'd you give a "Ship It!" here, but then went back to patches
earlier in the chain and asked for test results (provided in the patch previous to this)?

I'd like to chat with you about this. From my look with Review Board, I now don't see "test
results" here. I thought I did before.

I think I'm confused about how Review Board works. Stop by when you get in and explain what
I'm missing, thanks!


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58449/#review172258
-----------------------------------------------------------


On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58449/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 2:10 a.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake
> 3.7.0, and is necessary to most cleanly build an external CMake built
> project where the `CMakeLists.txt` is in a subfolder of the project.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f 
> 
> 
> Diff: https://reviews.apache.org/r/58449/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message