mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <>
Subject Re: Review Request 58304: Remove unnecessary hashmap lookups.
Date Wed, 19 Apr 2017 22:07:21 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 19, 2017, 10:07 p.m.)

Review request for mesos, Adam B, Mesos Reviewbot, and Neil Conway.

Bugs: MESOS-7372

Repository: mesos


In a number of places, we tested whether the slaves hashmap contains
the desired element before indexing it. It is safe to just index it and
check for a NULL result, which saves us some hashing and lookups.


  src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297 



Make check (Fedora 25). Internal fuzzing.


James Peach

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message