mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 58304: Remove unnecessary hashmap lookups.
Date Wed, 19 Apr 2017 22:05:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58304/
-----------------------------------------------------------

(Updated April 19, 2017, 10:05 p.m.)


Review request for mesos, Adam B, Mesos Reviewbot, and Neil Conway.


Bugs: MESOS-7372
    https://issues.apache.org/jira/browse/MESOS-7372


Repository: mesos


Description
-------

In a number of places, we tested whether the slaves hashmap contains
the desired element before indexing it. It is safe to just index it and
check for a NULL result, which saves us some hashing and lookups.


Diffs (updated)
-----

  src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297 


Diff: https://reviews.apache.org/r/58304/diff/6/

Changes: https://reviews.apache.org/r/58304/diff/5-6/


Testing
-------

Make check (Fedora 25). Internal fuzzing.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message