mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <>
Subject Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.
Date Wed, 19 Apr 2017 22:04:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 19, 2017, 10:04 p.m.)

Review request for mesos, Adam B, Mesos Reviewbot, and Neil Conway.

Bugs: MESOS-7372

Repository: mesos


In all cases where we call Master::removeTask, we have the correct slave
pointer in hand. We can just pass it down, avoiding the need to look it
up again with the SlaveID.

Diffs (updated)

  src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 
  src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297 




Make check (Fedora 25). Internal fuzzing.


James Peach

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message