mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 58512: Avoid a crash in HTTP decoder.
Date Wed, 19 Apr 2017 16:02:39 GMT


> On April 19, 2017, 4:02 a.m., Anand Mazumdar wrote:
> > Looks good! Thanks for reporting the issue and also fixing it.
> > 
> > Can you add a test to go along with the fix? Otherwise, under the "Testing Done"
section, the tests are _always_ expected to pass with/without the fix.

Absolutely. Added 2 tests for this change. Confirmed the tests fail without the code changes,
and pass with these changes.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58512/#review172304
-----------------------------------------------------------


On April 19, 2017, 4:02 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58512/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 4:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, James Peach, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7400
>     https://issues.apache.org/jira/browse/MESOS-7400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the callback `on_headers_complete()` fails, the decoder's writer
> object is `None()`. So, when the callback `on_message_complete()` is
> called, we should not crash in that case.
> Note that the `CHECK(decoder->writer)` is valid for the callback
> `on_body()` is valid since this callback is called only on a success
> in `on_headers_complete()` callback.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp 4c779d42548958e610142438a57529ccb4478053 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp c0efef571815752cc28e5a0dc7a07adc82bb31d5

> 
> 
> Diff: https://reviews.apache.org/r/58512/diff/2/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message