mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 58485: Avoid a corruption while rescinding offers.
Date Wed, 19 Apr 2017 02:49:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58485/
-----------------------------------------------------------

(Updated April 19, 2017, 2:49 a.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Changes
-------

Addressed review comments.


Bugs: MESOS-7308
    https://issues.apache.org/jira/browse/MESOS-7308


Repository: mesos


Description
-------

When a `DESTROY` is processed, we rescind all pending offers to which
persistent volumes have been offered. As soon as we rescind an offer,
the `Offer` object is freed; and hence, we should move on to the next
offer (even though there are multiple volumes being destroyed in
the same `ACCEPT` call).


Diffs (updated)
-----

  src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297 
  src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 


Diff: https://reviews.apache.org/r/58485/diff/2/

Changes: https://reviews.apache.org/r/58485/diff/1-2/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message