mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 56895: Allow agents to recover slave state post a reboot.
Date Wed, 19 Apr 2017 01:10:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56895/
-----------------------------------------------------------

(Updated April 19, 2017, 1:10 a.m.)


Review request for mesos, Neil Conway and Jiang Yan Xu.


Bugs: MESOS-6223
    https://issues.apache.org/jira/browse/MESOS-6223


Repository: mesos


Description
-------

With partition awareness, the agents are now allowed to re-register
after they have been marked Unreachable. The executors are anyway
terminated on the agent when it reboots so there is no harm in
letting the agent keep its SlaveID, re-register with the master
and reconcile the lost executors. This is a pre-requisite for
supporting persistent/restartable tasks in mesos.


Diffs (updated)
-----

  src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 
  src/slave/slave.cpp 4ff522e75bc8de34fe2e7720bdd8ce3d32cbf803 
  src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 
  src/slave/state.cpp 33dcc7a148f9a6b1a3216cce45710da8fd819ba6 
  src/tests/reservation_tests.cpp 4504831d77c1bfcf5f2ddf6d28cd45dea2c421ad 
  src/tests/slave_recovery_tests.cpp 53f33a2b0411c8158326074ce043c7b1dbeef5b4 


Diff: https://reviews.apache.org/r/56895/diff/4/

Changes: https://reviews.apache.org/r/56895/diff/3-4/


Testing
-------

make check


Thanks,

Megha Sharma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message