mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.
Date Tue, 18 Apr 2017 22:22:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58305/
-----------------------------------------------------------

(Updated April 18, 2017, 10:22 p.m.)


Review request for mesos, Mesos Reviewbot and Neil Conway.


Changes
-------

Rebases and addresse review feedback.


Bugs: MESOS-7372.
    https://issues.apache.org/jira/browse/MESOS-7372.


Repository: mesos


Description
-------

The ReRegisterSlaveMessage message sends a number of fields which have
internal consistency requirements. Add some simple validation checks
to ensure that we have a minimally consistent re-registration request
before proceeding.


Diffs (updated)
-----

  src/master/master.cpp 0f4c64c6b102ef201779a331c96b5d78a98281ad 
  src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e 
  src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa 


Diff: https://reviews.apache.org/r/58305/diff/5/

Changes: https://reviews.apache.org/r/58305/diff/4-5/


Testing
-------

Make check (Fedora 25). Internal fuzzing.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message