mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Review Request 58487: Fix allocation quantities when shared resources are removed.
Date Mon, 17 Apr 2017 23:14:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/
-----------------------------------------------------------

Review request for mesos, James Peach and Jiang Yan Xu.


Bugs: MESOS-7308
    https://issues.apache.org/jira/browse/MESOS-7308


Repository: mesos


Description
-------

When shared resources are removed from the `allocations` in the sorter,
we remove the scalar quantity only when the shared resource is actually
removed (i.e. shared count goes down to 0). Similarly, we increase the
scalar quantity only when this is a new shared resource that is being
added to the `allocations`.


Diffs
-----

  src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295 


Diff: https://reviews.apache.org/r/58487/diff/1/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message