mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 57815: Added `suppress` field in SUBSCRIBE.
Date Mon, 17 Apr 2017 22:25:19 GMT


> On April 17, 2017, 6:28 p.m., Vinod Kone wrote:
> > include/mesos/scheduler/scheduler.proto
> > Lines 249-250 (original), 249-250 (patched)
> > <https://reviews.apache.org/r/57815/diff/1-3/?file=1670985#file1670985line249>
> >
> >     Hmm, I was hoping that we could re-use the `Call::Suppress` message here instead
of re-defining it. That way any changes to suppress would be in sync.

Currently, `Call::Suppress` is:
```
  message Suppress {
    optional string role = 1;
  }
```

So, the `SUPPRESS` call currently allows suppressing offers for a framework on a per-role
basis (or all roles if `role` is not set). Since we now support multiple roles for a frameework,
and if we want to suppress offers for a subset of roles at the time of `SUBSCRIBE`, using
`Call::Suppress` would not satisfy that use case. It would only satisfy suppressing for all
roles (i.e. `Suppress::role` is not set) or for a specific role.

Is there any plans of extending `SUPPRESS` to suppress offers for a subset of roles (>0,
and < all roles) in a single call? Do you think we should consider that also?

One such approach could be to have the following:
```
  message Suppress {
    repeated string roles = 1;
  }

  optional Suppress suppress;
```

If suppress is not set, then we do not suppress for any roles. Otherwise, we suppress for
the set of roles specified in `suppress.roles`. If `suppress` is set but `suppress.roles`
is empty, we suppress for all roles of the framework.

Thoughts?


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57815/#review172115
-----------------------------------------------------------


On April 15, 2017, 6:40 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57815/
> -----------------------------------------------------------
> 
> (Updated April 15, 2017, 6:40 a.m.)
> 
> 
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7015
>     https://issues.apache.org/jira/browse/MESOS-7015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If set, offers are suppressed on registration for this framework.
> By default, offers shall not be suppressed on successful
> registration with the master.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto cee0a175fcdcbb8b56d41a5b4b6fd965afd822bd 
>   include/mesos/v1/scheduler/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee

> 
> 
> Diff: https://reviews.apache.org/r/57815/diff/3/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message