mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 58463: Overwriting Symbolic Links with Files in Copy Provisioner.
Date Mon, 17 Apr 2017 21:52:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/
-----------------------------------------------------------

(Updated April 17, 2017, 9:52 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Modified according to revision 4 of 58408.


Bugs: MESOS-6327
    https://issues.apache.org/jira/browse/MESOS-6327


Repository: mesos


Description
-------

When a layer overwrites a symbolic link with a regular file, the link
must be removed first, otherwise 'cp' would follow the link and
overwrite the target instead of the link itself.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d



Diff: https://reviews.apache.org/r/58463/diff/2/

Changes: https://reviews.apache.org/r/58463/diff/1-2/


Testing
-------

sudo make check

Manually tested with the following docker images:
  https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
  https://hub.docker.com/r/chhsiao/mycrosslink/  (simplist image to reproduce the same bug)


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message