mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.
Date Mon, 17 Apr 2017 20:14:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58303/#review172127
-----------------------------------------------------------




src/master/master.hpp
Line 760 (original), 760 (patched)
<https://reviews.apache.org/r/58303/#comment245219>

    Can you add a comment that `slave` might be `nullptr`?



src/master/master.cpp
Line 7886 (original), 7886 (patched)
<https://reviews.apache.org/r/58303/#comment245218>

    Can you move this down below the `CHECK(!slaves.registered.contains(...))` call? i.e.,
seems to make more sense to me to assert that there's no slave we need to update before doing
`updateTask()`.


- Neil Conway


On April 17, 2017, 4:14 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58303/
> -----------------------------------------------------------
> 
> (Updated April 17, 2017, 4:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Mesos Reviewbot, and Neil Conway.
> 
> 
> Bugs: MESOS-7372
>     https://issues.apache.org/jira/browse/MESOS-7372
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In all cases where we call Master::removeTask, we have the correct slave
> pointer in hand. We can just pass it down, avoiding the need to look it
> up again with the SlaveID.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 
>   src/master/master.cpp 0f4c64c6b102ef201779a331c96b5d78a98281ad 
> 
> 
> Diff: https://reviews.apache.org/r/58303/diff/4/
> 
> 
> Testing
> -------
> 
> Make check (Fedora 25). Internal fuzzing.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message