mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 58443: Unit test for file/symlink/directory overwriting in provisioners.
Date Mon, 17 Apr 2017 18:33:09 GMT


> On April 17, 2017, 2:25 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 729 (patched)
> > <https://reviews.apache.org/r/58443/diff/2/?file=1692899#file1692899line729>
> >
> >     Not yours, but I think we should rename ProvisionerDockerPullerTest to ProvisionerDockerTest,
and rename ProvisionerDockerWhiteoutTest to ProvisionerDockerBackendTest. We don't need this
new test fixture. We should just re-use ProvisionerDockerBackendTest (which iterates all available
backends).
> >     ```
> >     ProvisionerDockerBackendTest.XXX_Whiteout
> >     ProvisionerDockerBackendTest.XXX_Overwrite
> >     ```
> >     
> >     Let's pull the test renaming into a separate patch.

So should I keep this PR is it is right now and make a new PR depending on this one?


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review172065
-----------------------------------------------------------


On April 15, 2017, 12:46 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
> 
> (Updated April 15, 2017, 12:46 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5028 and MESOS-6327
>     https://issues.apache.org/jira/browse/MESOS-5028
>     https://issues.apache.org/jira/browse/MESOS-6327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test is based on the following image:
>   https://hub.docker.com/r/chhsiao/overwrite/
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083

> 
> 
> Diff: https://reviews.apache.org/r/58443/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message